teable icon indicating copy to clipboard operation
teable copied to clipboard

feat: implement duplicate row functionality

Open AliceLanniste opened this issue 1 year ago • 2 comments

close #796

AliceLanniste avatar Sep 20 '24 01:09 AliceLanniste

Pull Request Test Coverage Report for Build 10951572039

Details

  • 25 of 25 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on duplicate_row_new at 85.088%

Totals Coverage Status
Change from base Build 10943358602: 85.1%
Covered Lines: 36177
Relevant Lines: 42517

💛 - Coveralls

coveralls avatar Sep 20 '24 01:09 coveralls

Oops, conflict leading to new feature(comment), fortunately it is easy to resolve, i'll review it.

caoxing9 avatar Sep 20 '24 04:09 caoxing9

> Hi, I've been waiting too long for the merge pr.

Oops, conflict leading to new feature(comment), fortunately it is easy to resolve, i'll review it. Hi, I've been waiting too long for the merge this pr. when to merge this pr?

AliceLanniste avatar Oct 16 '24 14:10 AliceLanniste

I believe that every single-record right-click menu in each view needs to have a "Duplicate Record" menu item added, including both the grid view and the kanban view.

When I started to implement the duplicate functionality, I actually did it .

the comment in https://github.com/teableio/teable/pull/796#issuecomment-2315062591, let me implement it in expand card.

I'm a little dissatisfied with the current implementation,it can't insert a duplicate record after the index of the target record. so your team members should decide after discussing it.

AliceLanniste avatar Oct 19 '24 14:10 AliceLanniste

@boris-w hi, I have completed the pr. can you merge it?

AliceLanniste avatar Oct 28 '24 12:10 AliceLanniste

Looks like there's a problem merging some files.

boris-w avatar Oct 29 '24 03:10 boris-w

what can't files be merged. the result of ci is no conflicts with the base branch. so I don't know what to do next.

AliceLanniste avatar Oct 29 '24 08:10 AliceLanniste

what can't files be merged. the result of ci is no conflicts with the base branch. so I don't know what to do next.

It looks like you're using merge instead of rebase.

boris-w avatar Oct 29 '24 09:10 boris-w

what can't files be merged. the result of ci is no conflicts with the base branch. so I don't know what to do next.

It looks like you're using merge instead of rebase.

OK ,now it‘s work tree is clean

AliceLanniste avatar Oct 29 '24 10:10 AliceLanniste