bdq icon indicating copy to clipboard operation
bdq copied to clipboard

TG2-VALIDATION_MINELEVATION_INRANGE

Open iDigBioBot opened this issue 7 years ago • 15 comments

Field Value
GUID 0bb8297d-8f8a-42d2-80c1-558f29efe798
Label VALIDATION_MINELEVATION_INRANGE
Description Is the value of dwc:minimumElevationInMeters within the Parameter range?
Output Type Validation
Darwin Core Class Location
Information Elements dwc:minimumElevationInMeters
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:minimumElevationInMeters is EMPTY or the value is not a number; COMPLIANT if the value of dwc:minimumElevationInMeters is within the range of bdq:minimumValidElevationInMeters to bdq:maximumValidElevationInMeters inclusive; otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions MINELEVATION_INRANGE
Warning Type Invalid
Parameter(s) Default values: bdq:minimumValidElevationInMeters="-430"; bdq:maximumValidElevationInMeters="8850"
Source Authority
Examples [dwc:minimumElevationInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:minimumElevationInMeters is IN_RANGE"]
[dwc:minimumElevationInMeters="-500": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:minimumElevationInMeters is NOT_IN_RANGE (<-430)"]
Source ALA, GBIF
References
  • Wikipedia (2020). List of elevations extremes by country (https://en.wikipedia.org/wiki/List_of_elevation_extremes_by_country_
  • Wikipedia 2020. Extreme points of Antarctica (https://en.wikipedia.org/wiki/Extreme_points_of_Antarctica
  • Chapman, AD and Wieczorek, JR (2020). Georeferencing Best Practices. Copenhagen: GBIF Secretariat (https://doi.org/10.15468/doc-gg7h-s853)
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes We have rounded up the Parameter values. We are aware of sub-ice elevations in Antarctica to -3,500m and possible sampling in the atmosphere above the elevation of the top of Mt Everest that would fail this test but we support the odd false positive.

iDigBioBot avatar Jan 05 '18 15:01 iDigBioBot

Comment by Paula Zermoglio (@pzermoglio) migrated from spreadsheet: Elevation CAN be less than 0, and I would not expect it to be more than 8,848m (Mt. Everist summit)

iDigBioBot avatar Jan 05 '18 15:01 iDigBioBot

Comments from Gainesville: Need to split into two tests

ArthurChapman avatar Jan 16 '18 17:01 ArthurChapman

'if the value of the field dwc:maximumElevationInMeters is number between -423 and 8850 inclusive' -should that be dwc:minimumElevationInMeters? Also is there a reason for -423 as lower bound? I understand, possibly incorrectly, that the lowest is the Dead Sea shore at -413m.

ianengelbrecht avatar Mar 11 '19 13:03 ianengelbrecht

Thanks @ianengelbrecht - yes should be minimum and not maximum (I have fixed). Thanks for picking that up. I see that the reference we cite https://en.wikipedia.org/wiki/List_of_elevation_extremes_by_country has been updated and the Dead Sea has been changed from -423 to -428 (perhaps other references give different values). I have corrected that in the expected response above. Should we alter this to -430 (-450) or something to allow rounding. What do you think @tucotuco

ArthurChapman avatar Mar 11 '19 21:03 ArthurChapman

@tucotuco I see that the reference we cite has Mt Everest at 8848 m. We seem to have rounded that to 8850, so perhaps we should round the minimum to -430 especially as the Wikipedia footnote (34) states that it falls about 1 m per year and gives -428 as the 2014 level. I am also wondering if Wikipedia is the best reference here, or a more permanent reference?

ArthurChapman avatar Mar 11 '19 21:03 ArthurChapman

Just back on deck. Thanks @ianengelbrecht and @ArthurChapman. I agree that we should round these limits out to -430 to +8850, but I wonder then if this one is 'Parameterized' so that installers/implementers could provide their own min/max?

Tasilee avatar Mar 14 '19 04:03 Tasilee

Interesting suggestion, @Tasilee. If it was parameterized (for example if someone was working in Australia and wanted to set the maximum and minimum for Australia) that would make sense. We would then default to -430 to +8850 as the default if parameter not set. Would need to rewrite and put a note to the effect that if the parameter is not set it reverts to -430 to +8850

ArthurChapman avatar Mar 14 '19 06:03 ArthurChapman

I like the idea of rounding a bit beyond the extremes. It will avoid discussions (hopefully) of what different sources have to say.

I really like the idea of a parametrized test. We could create a reference data set of extremes by country code as well.

tucotuco avatar Mar 24 '19 20:03 tucotuco

Data Quality Dimension isn't correct. This is a test of Likelihood, not Conformance, as there is no standard to conform to, just the distribution of likelyhood of occurrences against elevations within some region of interest.

We should check all tests that assert a data quality dimension of Conformance to make sure that they do actually involve the data conforming to some standard rather than being a test of likely values in the real world.

chicoreus avatar Aug 10 '19 16:08 chicoreus

I notice that the Expected Response doesn't include the possibility of Paramaterization as discussed in comments above. Probably needs rewriting to allow for Paramaterization

ArthurChapman avatar Aug 10 '19 22:08 ArthurChapman

I agree with @chicoreus and amended Dimension and will check Conformance on others next.

@ArthurChapman: How do we refer to Parameters? Maybe like this: INTERNAL_PREREQUISITES_NOT_MET if the field dwc:minimumElevationInMeters is not present, is EMPTY or is not a number; COMPLIANT if the value of the field dwc:minimumElevationInMeters conforms to Parameters; otherwise NOT_COMPLIANT ? This would reduce edits.

Tasilee avatar Aug 12 '19 01:08 Tasilee

Do all agree that #24, #107 (and this one) should be Data Quality Dimension = Likelihood?

What about #108? I presume Conformance.

Tasilee avatar Aug 12 '19 01:08 Tasilee

@Tasilee I think your wording makes sense and would lead to consistency throughout - especially if we then use a namespace for the Parameters. How does this fit with the coding @chicoreus

Not sure about #24 and #108 being Likelihood - it is Conformance - because the minimum elevation cannot ever be greater than maximum elevation and same for depth. @chicoreus? I am not sure you are correct wrt to Conformance and Range - definition of Conformance "From the FFU Framework: A Data Quality Dimension (q.v.) - conforms to a format, syntax, type, range, standard, or to the own nature of the Information Element (q.v.)." NB "range" in the definition. Likelliness: From the FFU Framework: "A Data Quality Dimension (q.v.) - probability of data having the expected value; the likelihood of a data having true values rather than having false values".

ArthurChapman avatar Aug 12 '19 01:08 ArthurChapman

As we are providing elevation limits, the result either conforms to this range or it does not. There is no likeliness about it.

Tasilee avatar Aug 16 '19 04:08 Tasilee

Added "of bdq:minimumValidElevationInMeters to bdq:maximumValidElevationInMeters inclusive" in COMPLIANT for consistency with other related tests

ArthurChapman avatar Mar 26 '22 01:03 ArthurChapman

Edited Parameter(s) and Source authority to align with proposed structure and format

Tasilee avatar Jun 13 '23 00:06 Tasilee

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted"

Tasilee avatar Sep 16 '23 04:09 Tasilee