bdq icon indicating copy to clipboard operation
bdq copied to clipboard

TG2-VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION

Open iDigBioBot opened this issue 7 years ago • 9 comments

TestField Value
GUID d708526b-6561-438e-aa1a-82cd80b06396
Label VALIDATION_MINELEVATION_LESSTHAN_MAXELEVATION
Description Is the value of dwc:minimumElevationInMeters a number less than or equal to the value of dwc:maximumElevationInMeters?
TestType Validation
Darwin Core Class dcterms:Location
Information Elements ActedUpon dwc:minimumElevationInMeters
dwc:maximumElevationInMeters
Information Elements Consulted
Expected Response INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is bdq:Empty, or if either is not a number; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT
Data Quality Dimension Conformance
Term-Actions MINELEVATION_LESSTHAN_MAXELEVATION
Parameter(s)
Source Authority
Specification Last Updated 2023-09-18
Examples [dwc:minimumElevationInMeters="0", dwc:maximumElevationInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=COMPLIANT, Response.comment="dwc:minimumElevationInMeters is equal to dwc: maximumElevationInMeters"]
[dwc:minimumElevationInMeters="1", dwc:maximumElevationInMeters="0": Response.status=RUN_HAS_RESULT, Response.result=NOT_COMPLIANT, Response.comment="dwc:minimumElevationInMeters is greater than dwc:maximumElevationInMeters"]
Source @Tasilee
References
  • Chapman AD and Wieczorek JR (2020) Georeferencing Best Practices. Copenhagen: GBIF Secretariat. https://doi.org/10.15468/doc-gg7h-s853
Example Implementations (Mechanisms)
Link to Specification Source Code
Notes

iDigBioBot avatar Jan 05 '18 16:01 iDigBioBot

Comment by Lee Belbin (@Tasilee) migrated from spreadsheet: Validation equivalent to amendment

iDigBioBot avatar Jan 05 '18 16:01 iDigBioBot

For consistency with #112 and #39 and #24 should probably have internal prerequisites not met if either of the information elements has a value that is not a number.

Propose changing:

INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is EMPTY; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT

To:

INTERNAL_PREREQUISITES_NOT_MET if dwc:maximumlevationInMeters or dwc:minimumElevationInMeters is EMPTY or either is not a number; COMPLIANT if the value of dwc:minimumElevationInMeters is a number less than or equal to the value of the number dwc:maximumElevationInMeters, otherwise NOT_COMPLIANT

chicoreus avatar Feb 19 '22 22:02 chicoreus

Agree

ArthurChapman avatar Feb 19 '22 22:02 ArthurChapman

Agree

On Sat, Feb 19, 2022 at 7:28 PM Arthur Chapman @.***> wrote:

Agree

— Reply to this email directly, view it on GitHub https://github.com/tdwg/bdq/issues/108#issuecomment-1046116133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADQ725ODWSFJZGJX2YQJKTU4AKRNANCNFSM4EKSRYRA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

tucotuco avatar Feb 20 '22 01:02 tucotuco

I agree and have made the change.

Tasilee avatar Feb 21 '22 02:02 Tasilee

I note that we have used here "is not a number;" but elsewhere (e.g., #87) we use "interpretable as a number". How do you want to play this? I'd opt for the former (Occam).

Also, I presume the ER would also apply to #24?

Tasilee avatar Feb 21 '22 02:02 Tasilee

"is a number" sounds simple even if it might not be as rigorously correct. An example would be for the month field because entomologists use Roman numerals, but we say "is an integer" there, so it seems perfectly reasonable to say "is a number" here.

I'm not sure what you mean by "also apply to #24", but certainly the pattern should be consistent.

tucotuco avatar Feb 21 '22 04:02 tucotuco

I have aligned the Expected Response of #24 with this one.

Tasilee avatar Feb 21 '22 22:02 Tasilee

Splitting bdqffdq:Information Elements into "Information Elements ActedUpon" and "Information Elements Consulted".

Also changed "Field" to "TestField", "Output Type" to "TestType" and updated "Specification Last Updated"

Tasilee avatar Sep 18 '23 02:09 Tasilee