Teal Dulcet

Results 165 comments of Teal Dulcet

In the resulting JSON data, words in the [Serbo-Croatian language](https://en.wikipedia.org/wiki/Serbo-Croatian) are now listed under the `bs` code (for Bosnian) when they [should be](https://en.wiktionary.org/wiki/Category:Serbo-Croatian_language) listed under `sh` (or maybe `hbs` for...

@zatricky All your requested changes have been made in https://github.com/mail-in-a-box/mailinabox/pull/1457/commits/93fe6bf15313b74552fb72164237a10077a4a7fb.

There are plenty of "actual" bugs here. For example, I quoted all occurrences of the `STORAGE_ROOT` and `STORAGE_USER` variables, because the directories could contain a space, which would currently cause...

> We really should fix this: > Maybe most of these problems are harmless, but having > a chance to spot new problems is worth the effort. Thanks, I agree....

Thanks Josh for your response. I can try to break this up into more commits, but note that many of the issues can now be fixed automatically by just running...

> The way to get the changes merged is to create smaller commits with one type of change per commit so that it's easy for me to understand what the...

@JoshData - I do not believe you meant to close this, as #2342 only fixed the ShellCheck issues in one of the 27 files this PR addresses.

No problem. Yes, I will rebase this PR from the main branch.

> for the note: testing with travis won't work as we've got to spawn a full VM with many services. Memory requirements with travis are ridiculously low. Travis CI provides...

> Can you explain what's going on in some of the steps? https://github.com/mail-in-a-box/mailinabox/blob/4f64f51bd064251c36c583c13bf3f4443db36323/.travis.yml#L13 Adds a hostname to the hosts file. https://github.com/mail-in-a-box/mailinabox/blob/4f64f51bd064251c36c583c13bf3f4443db36323/.travis.yml#L14-L15 Updates the apt package database and upgrades all currently...