tds_fdw icon indicating copy to clipboard operation
tds_fdw copied to clipboard

Published 20 hours ago • verified publisher icon tds-fdw

Add support for user-defined data types (Sybase only)

Open vitalca opened this issue 1 year ago • 7 comments

Related issue: #323

vitalca avatar Nov 07 '22 21:11 vitalca

Can one of the admins verify this patch?

jenkins-juliogonzalez avatar Nov 07 '22 21:11 jenkins-juliogonzalez

Test this, please

GeoffMontee avatar Nov 09 '22 22:11 GeoffMontee

Test PASSed.

jenkins-juliogonzalez avatar Nov 09 '22 22:11 jenkins-juliogonzalez

Let's test it again, and if so, maybe it can be merged.

Test this, please.

juliogonzalez avatar Apr 09 '23 21:04 juliogonzalez

Test PASSed.

jenkins-juliogonzalez avatar Apr 09 '23 21:04 jenkins-juliogonzalez

Hi @vitalca ,

Thanks for the PR! Sorry for letting this one sit for a while.

What do you think about the following changes for this?:

  • Allow different foreign servers to have different keep_untranslatable_types values by changing it from a custom boolean variable to a server option defined in src/options.c
  • Add some documentation for keep_untranslatable_types to ForeignServerCreation.md

GeoffMontee avatar Jul 20 '23 17:07 GeoffMontee

Hi @GeoffMontee,

That makes sense. Thanks for the suggestion! I am a Java developer, but what you suggested is seemingly easy to implement. Let me give it a try.

vitalca avatar Jul 20 '23 19:07 vitalca