tdruez
tdruez
You are putting side by side a form submit button "Scan License" and a navigation link "New Project". I think the "New Project" as no need to be present in...
> please suggest changes This looks awesome but where is the code? No code, no review possible. > any resource for recommending license? I don't know what you mean by...
@lf32 please read the following for future commit messages (no need to update the existing ones): https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html For example: "changed card title from name to short_name" should be "Change card...
> should the user have a checkbox to decide if they have to detect unknown licenses or should we just set it to true by default It's not yet the...
@lf32 your recent changes in `get_licenses` breaks the detection of simple content such as "Apache 2.0". Is this behavior expected?
> Yes I guess, when tempfile is not flushed with temp_file.flush() I think the file doesn't get written to disk and get_licenses cant read it from the beginning Keep the...
Also, you haven't answer to my questions from my previous comment: - Also, what's the deal with all the force-pushed in your commit history? This is a source of issues...
> Is it like how demo.grammarly.com does? > It sounds great and I'm working on it That UI looks pretty good, I like that we could use different colors based...
> based on score? I was thinking more about [License Policies and Compliance Alerts](https://scancodeio.readthedocs.io/en/latest/tutorial_license_policies.html#license-policies-and-compliance-alerts) You can start using the score for the initial implementation though, since the value is already...
> @tdruez what do you think about [github's changelog?](https://github.blog/changelog/) @lf32 In which context? I'm not familiar with it.