working-plusplus
working-plusplus copied to clipboard
tdmalone
Added ==
Added == and made it where bot can get points as well. @bot == will throw error in log but does work.
Pull Request Test Coverage Report for Build 105
- 6 of 21 (28.57%) changed or added relevant lines in 5 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-2.4%) to 69.61%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/operations.js | 0 | 1 | 0.0% |
| src/messages.js | 2 | 4 | 50.0% |
| src/events.js | 2 | 7 | 28.57% |
| src/points.js | 1 | 8 | 12.5% |
| <!-- | Total: | 6 | 21 |
| Totals | |
|---|---|
| Change from base Build 89: | -2.4% |
| Covered Lines: | 260 |
| Relevant Lines: | 350 |
💛 - Coveralls
Thanks for this @MattLParker!
There's a few things I'd like to change before getting this into master, primarily fixing a bit of duplicate code and updating some inline documentation. I know you've already put a lot of effort into this; are you interested in some detailed feedback or would you prefer I make the changes and go from there?
Hey, We are using the code on a slack group already as is. I'm really just trying to dig into JS, So feel free to make changes and I will watch and learn :)
No probs! I'll aim to get to it this weekend :)
Thanks again for contributing the code back!
Oh, and on tone, I'm happy with the messages for now, I'll work out better wording for us and change that separately.
Our main repo for our slack is https://github.com/winadminsdotorg/PointsBot I also just added a @user ## to random give or take a point. Follow us if your interested in pulling any features, I won't bother with PRs.
Our main repo for our slack is https://github.com/winadminsdotorg/PointsBot I also just added a @user ## to random give or take a point. Follow us if your interested in pulling any features, I won't bother with PRs.
90% of the "problems" with this PR is the site-specific stuff. Implementing that properly is next on my list for development (once I get back to this project).
Please feel free to send us more PRs!