tdlight-telegram-bot-api icon indicating copy to clipboard operation
tdlight-telegram-bot-api copied to clipboard

Handle lost connection to telegram servers gracefully

Open luckydonald opened this issue 4 years ago • 6 comments

Currently, if telegram isn't working, requests are simply left open, stalling forever.

That's not great as that means basically DDoS potential.

To Reproduce:

  1. Lauch bot api
  2. Disconnect Wifi or whatever
  3. Send a request to the Bot API.
  4. ????
  5. Boom

luckydonald avatar Feb 15 '21 16:02 luckydonald

So I think it should just return an error right away. Just like the Internal Server Error: restart one.

luckydonald avatar Feb 15 '21 17:02 luckydonald

@luckydonald I don't get it

penn5 avatar Feb 15 '21 17:02 penn5

It should work with the next update, I'm closing this issue. Reopen it if the problem exists also in the next update.

cavallium avatar Jun 26 '21 10:06 cavallium

Any concrete commit fixing this?

luckydonald avatar Jun 28 '21 21:06 luckydonald

Is still not working with the current release?

cavallium avatar Jun 28 '21 21:06 cavallium

No idea, didn't test yet. I was rather curious by what it could be fixed now.

Like, did a upstream merge change that, or did one of you lovely people fix it?

luckydonald avatar Jun 28 '21 21:06 luckydonald