Toby Dylan Hocking

Results 319 comments of Toby Dylan Hocking

and yes I think this was handled by coord_transform in old ggplot2 however I don't think we should go back to using that, since it does not work with update_axes....

thanks for trying to implement that solution. what exactly was the problem that you encountered? it seems to me that it should be possible to do the following: (1) use...

by the way there is a workaround: just replace the Inf values with finite values in the data set or aes definition. It is annoying and the values are not...

thanks for clarifying the problem. that makes sense that we can't do it entirely in saveLayer, since we do not have access to the scale limits (domains) there. and yes...

Hey Faizan thanks for all of these changes, especially for cleaning up the parsePlot / meta mess. About point 3. can you please explain why it is not possible to...

Thanks for your very clear explanation Faizan. However I'm not sure to have understood the point about "the renderer would have to display the same axis range every time." It...

ok, thanks for the clarification. but actually I made a mistake, I meant to say that choice (2) will be easier to maintain in the long run, since there is...

and I agree with your comment that "having the code for replacing Inf at two different places is a bit of bad programming practice"

great. about point 4, I think "the Inf values are just replaced with the most extreme values in the panel" is almost the same thing that ggplot2 does. Rather than...

that sounds great. Thanks Faizan.