animint2 icon indicating copy to clipboard operation
animint2 copied to clipboard

animint.js Selectors does not need hasOwnProperty

Open tdhock opened this issue 3 months ago • 3 comments

there are several uses of Selectors.hasOwnProperty which seems to be un-necessary, so should be removed.

grep  -nH --null Selectors.hasOwnProperty animint.js
animint.js:1570:            if (Selectors.hasOwnProperty(selector_name)) {
animint.js:1866:    if(Selectors.hasOwnProperty(selector_name)){
animint.js:2087:    if(!Selectors.hasOwnProperty(v_name)){
animint.js:2766:        if(Selectors.hasOwnProperty(selector_nam)){
animint.js:2797:        }//if(Selectors.hasOwnProperty(selector_nam))

Grep finished with matches found at Tue Nov 25 09:55:05

tdhock avatar Nov 25 '25 14:11 tdhock

can i work on this ?

harshiittttt avatar Dec 15 '25 12:12 harshiittttt

sure, thanks

tdhock avatar Dec 15 '25 15:12 tdhock

I’ve opened PR #284 with a fix for all current hasOwnProperty occurrences in the animint.js source. Since this area overlaps with the earlier pending PR, I wanted to check your preference. Would you like me to base my branch on that PR or keep this as a clean, standalone fix based on main?

harshiittttt avatar Dec 15 '25 17:12 harshiittttt