theme(panel.margin=grid::unit(positive_number, "lines")) should work

[tdhock]

but it does not. Tests are mostly for zero instead of positive:

-*- mode: grep; default-directory: "~/R/animint2/tests/testthat/" -*-
Grep started at Mon Jan 20 11:42:42

grep --color -nH --null -e panel.margin *
grep: _snaps: est un dossier
test-compiler-errors.R\0153:    theme(panel.margin=grid::unit(0, "lines"))+
test-compiler-errors.R\0181:    theme(panel.margin=grid::unit(0, "lines"))+
test-compiler-geom-line-path.R\072:       theme(panel.margin=grid::unit(0, "lines"))+
test-compiler-pt-to-lines.r\08:panel_margin_lines <- pt.to.lines(theme.pars$panel.margin)
test-compiler-pt-to-lines.r\010:if(grid::unitType(theme.pars$panel.margin) %in% c("pt", "points")) {
test-compiler-pt-to-lines.r\015:    expect_false(identical(panel_margin_lines, theme.pars$panel.margin))
test-renderer1-many-facets.R\010:  theme(panel.margin=grid::unit(0, "cm"))
test-renderer1-panels.R\017:          panel.margin = grid::unit(0.1, "cm")) +
test-renderer1-PeakConsistency.R\019:         theme(panel.margin=grid::unit(0, "cm"))+
test-renderer1-PeakConsistency.R\074:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer1-variable-value.R\087:         theme(panel.margin=grid::unit(0, "cm"))+
test-renderer1-variable-value.R\0198:         theme(panel.margin=grid::unit(0, "cm"))+
test-renderer2-PredictedPeaks.R\071:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer2-PredictedPeaks.R\0207:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer2-VariantModels.R\067:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer2-VariantModels.R\0100:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer2-VariantModels.R\0145:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer2-widerect.R\070:    theme(panel.margin=grid::unit(0, "lines"))+
test-renderer3-ChromHMMinit.R\027:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer3-ChromHMMinit.R\050:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer3-ChromHMMinit.R\056:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer3-ChromHMMiterations.R\025:    theme(panel.margin=grid::unit(0, "cm"))+
test-renderer3-Inf.R\015:      panel.margin=grid::unit(0, "lines"))+
test-renderer3-Inf.R\086:      panel.margin=grid::unit(0, "lines"))+
test-renderer3-Inf.R\097:      panel.margin=grid::unit(0, "lines"))+
test-renderer3-knn.R\0128:  theme(panel.margin=grid::unit(0, "lines"))
test-renderer3-make-xrect.R\020:    theme(panel.margin=grid::unit(0, "lines"))+
test-renderer3-prostateLasso.R\025:    theme(panel.margin=grid::unit(0, "lines"))+
test-renderer3-roc.R\051:  theme(panel.margin=grid::unit(0, "lines")),
test-renderer3-roc.R\0102:  theme(panel.margin=grid::unit(0, "lines")),
test-renderer3-stat-bin.R\021:    theme(panel.margin=grid::unit(0, "lines"))+
test-renderer3-stat-bin.R\042:    theme(panel.margin=grid::unit(0, "lines"))+

we should double check these tests:

test-compiler-pt-to-lines.r\08:panel_margin_lines <- pt.to.lines(theme.pars$panel.margin)
test-compiler-pt-to-lines.r\010:if(grid::unitType(theme.pars$panel.margin) %in% c("pt", "points")) {
test-compiler-pt-to-lines.r\015:    expect_false(identical(panel_margin_lines, theme.pars$panel.margin))

test-renderer1-panels.R\017:          panel.margin = grid::unit(0.1, "cm")) +

[tdhock]

would be useful in this example https://github.com/animint/animint-manual-en/edit/main/chapters/Ch09/Ch09-Montreal-bikes.qmd

[ANAMASGARD]

Sir I have raised a PR related to this issue please review it and give your feedback and Happy Christmas in advance 🎄