should we remove stats/positions from docs?
in animint2 we don't really use stat_* nor position_* but they appear in the docs, https://animint.github.io/animint2/reference/geom_hex.html which may be confusing.
To clarify: Are you advocating for removing all stat_ and position_ functions, or are you advocating for removing them from the documentation but not from the animint2 package? :O
I agree that neither set of functions is really animint2's idiom (though ofc you would know better than me). They are occasionally helpful, though. Like, someone might call position_jitter() to limit overplotting.
probably would be good to remove both, so we would not have to write docs like this which explain features to avoid https://rcdata.nau.edu/genomic-ml/animint2-manual/Ch07-limitations.html#stats
That’s a pretty good argument. I do think some of the functions are both useful and compatible with animint2, but I guess they can call the tidyverse if they really want e.g. jittering.On Oct 17, 2024, at 10:59 PM, Toby Dylan Hocking @.***> wrote: probably would be good to remove both, so we would not have to write docs like this which explain features to avoid https://rcdata.nau.edu/genomic-ml/animint2-manual/Ch07-limitations.html#stats
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>
so now we have geom_label_aligned() which is not technically a stat/position, but the JS code for this geom does adjust the data positions, after applying showSelected, which is what I would consider a stat (the logic could be used with other geoms for example geom_text but currently it is limited to geom_label_aligned).