odftoolkit icon indicating copy to clipboard operation
odftoolkit copied to clipboard

Release candidate: ODF TOOLKIT 0.13.0

Open svanteschubert opened this issue 3 years ago β€’ 8 comments

For the release candidate of ODF TOOLKIT 0.12.0 I have done so far the following:

  1. Adjusted dependencies of ODF 1.2 to ODF 1.3,
  2. Re-generated ODFDOM calling: mvn clean install -Ppedantic -Dcodegen
  3. Tested the Taglets for attributes/elements/data-types and fixed the following anomalies:

Unicode Local Change

When I adjusted our existing ODF templates for new documents in ODFDOM from ODF 1.2 to ODF 1.3: https://github.com/tdf/odftoolkit/tree/master/odfdom/src/main/resources by using LibreOffice 7.4.3 (configured to use strict ODF 1.3) to load/save the templates. I had to adjust the version of the ODI (Image) and ODG (Graphic) file manually. (All validated as strict ODF 1.3 with https://odfvalidator.org/ ) Suddently, the there are by default Unicode Locales for the Unicode Groups and the three assertions return values: https://github.com/tdf/odftoolkit/blob/master/odfdom/src/test/java/org/odftoolkit/odfdom/doc/DocumentTest.java#L437 The test was adopted.

<manifest:key-derivation>

The element manifest:key-derivation has the choice of having either a single mandatory attribute value or multiple in ODF 1.3:

  • ODF 1.3: https://docs.oasis-open.org/office/OpenDocument/v1.3/os/schemas/OpenDocument-v1.3-manifest-schema-rng.html#key-derivation-attlist
  • ODF 1.2: https://github.com/tdf/odftoolkit/blob/master/generator/schema2template/src/test/resources/test-input/odf/grammar/OpenDocument-v1.2-os-manifest-schema.rng#L165

The code generator should better create two constructors one with a single and the other with three parameter, but it only provides the single paramater constructor, which occurred first. OdfPackage was adjusted for now, but code generator might better be improved.

SNAPSHOT Release

A SNAPSHOT released has been deployed to the Maven repository: https://oss.sonatype.org/content/groups/public/org/odftoolkit/odfdom-java/0.12.0-SNAPSHOT/

Upcoming Website (BETA)

A beta website is available to review upcoming site changes: https://svanteschubert.github.io/odftoolkit/index.html The release date 22.12.2022 was/is very optimistic! :-)

It has been 10 years since we updated an ODF version. Is there something further to be adjusted (some parts - like the grammars - have been prior already added to the ODF Validator and Generator project).

NOTE: The integration of this PR will fix and close #26.

svanteschubert avatar Dec 22 '22 00:12 svanteschubert

We have postponed the release just before FOSDEM so we have more time to review and test.

The following is already on my list:

  • [x] generate both constructors for the Package layer and undo the OdfPackage adoption
  • [ ] in this branch comments in the pom.xml look bad, some automatic indent broke it (which tool?)
  • [ ] Test the odfvalidator.war in Tomcat - does the new ODF 1.3 mimetype work?
  • [ ] Is the new Mimetype part of ODF 1.3? Validator commit: a8ed6696464b97f9cf04fa321428f45cdba4987e

svanteschubert avatar Dec 22 '22 17:12 svanteschubert

There is one show stopper in the generation that I will have to fix after FOSDEM: ODF has the attribue @text:value defined twice with different datatype:

  1. text:label/@text:value has datatype string
    https://docs.oasis-open.org/office/OpenDocument/v1.3/os/schemas/OpenDocument-v1.3-schema-rng.html#16807

  2. text:database-row-number"/@text:value hast datatype unsignedInteger https://docs.oasis-open.org/office/OpenDocument/v1.3/os/schemas/OpenDocument-v1.3-schema-rng.html#8733

This is currently ignored and not easy to add/fix in the current environment.

svanteschubert avatar Feb 03 '23 12:02 svanteschubert

after FOSDEM: Which year? πŸ˜…

dennisroczek avatar Feb 04 '23 14:02 dennisroczek

after FOSDEM: Which year? πŸ˜…

Of course in the correct year πŸ‘» (now stop the noise - sitting aside me in TDF devroom @FOSDEM and sending emails to public dev listπŸ™ˆ)

svanteschubert avatar Feb 04 '23 14:02 svanteschubert

Hi, is it possible to deploy a new snapshot to the Repository since 0.11.0 is not useable in OSGI environment? next, when will this version be released?

Boarschti42 avatar Oct 27 '23 10:10 Boarschti42

Hi, is it possible to deploy a new snapshot to the Repository since 0.11.0 is not useable in OSGI environment? next, when will this version be released?

Sure, I have just uploaded a SNAPSHOT release from current master branch by 'mvn deploy' you need to use the version number 0.12.0-SNAPSHOT as given in https://github.com/tdf/odftoolkit/blob/master/pom.xml#L26 and it should be accessibly downloaded when SNAPSHOT is given by your pom.xml You might download the JARs directly, e.g. for ODFDOM here: https://oss.sonatype.org/content/repositories/snapshots/org/odftoolkit/odfdom-java/0.12.0-SNAPSHOT/ Could you please test it if this works for you? I am not able to test any OSGI environment.

Hopefully this is helping you, Karsten!

Good luck with it! Svante

svanteschubert avatar Oct 27 '23 12:10 svanteschubert

The Unboxing/boxing PR contained many generated files: https://github.com/tdf/odftoolkit/pull/373/files This is just a note to myself to adjust the templates according to this PR...

svanteschubert avatar May 13 '25 14:05 svanteschubert