Thomas Dent

PyCBC live results should record when followup p-value was used and trials factors

3

For interpreting/improving the multi-ifo behaviour it is useful to know - ie record - whether the with-followup IFAR was larger and in any case to record the trials factor and/or...

Pycbc search workflow should require proxy init on restart

6

As a result of recent changes in LDG cluster login and/or pegasus, job submission fails if a fresh proxy is not available when a workflow is restarte d with './start'....

page_snrifar try/except prevents diagnosis of missing foreground

4

There are foreground events in an hdf file I am trying to plot but the 'cumulative' plot can't find them: see eg https://www.atlas.aei.uni-hannover.de/~tdent/LSC/o2/rates/catalog/H1L1-SNRIFAR_CUMULATIVE_O2.png . However because there is a try-except...

In pycbc_coinc_statmap, it seems like an error to make foreground censor veto windows on events _before_ clustering zerolag (https://github.com/gwastro/pycbc/blob/master/bin/all_sky_search/pycbc_coinc_statmap#L142). At least, since the pre-clustered events are not visible and not...

Code to override bank approximant is buggy

2

In waveform/bank.py : ``` # if approximant is specified, override whatever was in the file # (if anything was in the file) if approximant is not None: # get the...