teambot
teambot copied to clipboard
tdeck
Dockerify
TODOs:
- [x] Create a data volume for the shelve database.
- [ ] Update README to include Docker info.
- [ ] echo "TEAM_DB_FILE=/var/run/data/teambot.db" >> .env
Thanks for putting this together. Sadly I'm not a docker expert, but a couple of thoughts:
- Teambot willl create a file called teams.db that it persists to disc. Will that just work fine, or do you need a data volume?
- It would be great to have some a short section in the readme on how to run this with Docker, if there's anything required.
Sure, I can update the README and also add a new data volume to store the db.
To run it with Docker (which was useful in my local testing for my other two or so PRs):
docker-compose up
@tdeck Thoughts on this? I just rebased but wanted to check with you before I continue this work.
Yep, looks good in general. I just still have the inline question about that exposed port, and also I wonder what will happen with the team database if people use this configuration. I thought that generally things in a docker container were treated as ephemeral, and you were supposed to separate out the data. But I'm not really a docker user and I assume it depends on your platform.
@tdeck Not quite, been swapped here lately. Though I've not forgotten and will plan to make time for this ASAP.
@tdeck I cannot seem to find your inline comment. But I think I know what you're asking about: No, we probably don't need to expose anything. I just copy pasted that from another docker-based project I'm working on and must've forgotten to remove it. Good catch!
No hurry on my end, just want to make sure I wasn't neglecting anything. Let me know when you want me to take another look.