java-LSH icon indicating copy to clipboard operation
java-LSH copied to clipboard

Published 20 hours ago • verified publisher icon tdebatty

Correct signature size calculation

Open snie2012 opened this issue 6 years ago • 3 comments

According to the description in this file, signature size equals to R * b instead of R * s

snie2012 avatar Aug 07 '17 13:08 snie2012

Hi, I should check this very carefully, because I don't use the same notation as in the book:

  • the book calls bands (b) what I in the code call stages (s)
  • in the code b stands for buckets (per stage)

tdebatty avatar Aug 12 '17 15:08 tdebatty

Hi, I checked again based on your comment. It looks like my correction is wrong. Inside the computeSignatureSize function, r is the number of rows and s is the number of bands, so the signature size should be r * s. Please confirm! (The notations in the comments above the function are a little bit confusing, you might want to change that.)

By the way, the parameter n passed to computeSignatureSize is not used. Is this for consistency?

snie2012 avatar Aug 12 '17 17:08 snie2012

I also had a question about the parameter n not being used in computeSignatureSize.

@tdebatty, could you comment on this please? Thank you, in advance.

tavish avatar Jan 14 '19 17:01 tavish