Thibault Delavallée comments

Results 116 comments of


                                            Thibault Delavallée

[CLN][PRF] sale: another cleanup pass before v16

According to last guidelines, tags should be more like [LINT][PERF] :D Tde, doing useful reviews since 2011

[IMP] portal: avoid error modal on wizard modal superposition

Hello @Odoonan , Thanks for checking ! Indeed defining a void client action just for that is not cleaner than doing a custom behavior ^^ . Ok then, yet another...

[IMP] portal: avoid error modal on wizard modal superposition

@robodoo r+ rebase-merge

[IMP] web_unsplash: allow to specify image orientation

@robodoo r+

[IMP] web_unsplash: allow to specify image orientation

@robodoo r+

[IMP] web_unsplash: allow to specify image orientation

@robodoo r+

[IMP] web_unsplash: allow to specify image orientation

@robodoo p=1

[IMP] web_unsplash: allow to specify image orientation

Sorry, was not intended to break everything ^^ .

[IMP] web_unsplash: allow to specify image orientation

@robodoo retry

[FIX] phone_validation: fallback if no region provided

"None" is natively supported ? Cool ... Could you maybe have a small unit test for this one ?