Théo Daron

Yup but isn't shellword parsing done at each keypress for completion,... ? Would replacing before parsing using shellwords mean executing %sh at each keypress ? (I mean, each key typed...

It worked like this in the original PR but shellwords messed up with spaces inside variables expansion (eg: %sh{there are some spaces}) so I added a lil exception inside shellword...

Make sense, it's much clearer this way to me Shall I update this PR to be rebased on yours or shall we directly integrate command expansions inside your refactoring ?

> Unless there is some other reason for parsing the variables in Shellwords, I think this separates things pretty well. Don't completions need this ?

Nope, I am talking about the code inside the `command_mode` function (file `typed.rs`) to provide completion (but as I removed all completion specific code from the original PR I might...

> Is there a way we can increase the pop-up size? I'm attempting to get git log in a large pop-up instead of small one. Wouldn't more advanced solutions better...

Yep, atm the PR does not handle completions inside of %sh, but I am waiting an answer from core maintainers about which direction we should follow with @RoloEdits as I...

But you should get the desired behavior using `:sh git blame -L %{linenumber} %{filename}` I think, I didn't test

> > But you should get the desired behavior using `:sh git blame -L %{linenumber} %{filename}` I think, I didn't test > > This was just an example. What I...

ok. this problem was caused because commands in config.toml are not parsed using Shellwords but with a simple split(" ") which caused `%sh{echo %{filename}}` to be splitted in `%sh{echo` and...