Thijs Damsma

Results 46 comments of Thijs Damsma

This seems like a good change, but there is no test coverage for this. @pankus , do you feel comfortable adding a test that reproduces the desired behaviour? I don't...

I believe the regexes are cleaned for security reasons, as exposing full regex functionality might be a security risk. Not sure how much of a real vulnerability this is with...

Thanks for detailing your considerations, makes perfect sense now. I didn't know about bricknil, will check that out! Perhaps a pointer to bricknil would be nice, as your library ranks...

I believe the function 'onlyOne' is intended to demonstrate the power/convenience of coercion. But this function assumes that the input is coercible to a boolean, but not a numerical value...

@stevepiercy How do I setup testing with deformdemo? Does the widget need to be added to deformdemo first?

Ok great that there is interest. I'll try to make a standalone demo somewhere and get back to you

So as promised, here is a deformdemo fork with my widgets hacked in: https://github.com/tdamsma/deformdemo/tree/advanced-widgets. It includes a react jsonschema form that is build on top of (not instead of) the...

I added one more widget. I am aware the widgets would need some cleaning up etc, I just extracted them from an internal repo without refactoring properly. But hopefully this...

I understand the desire to put the widgets in deformdemo from a maintainers perspective, but how would it work for a user? Would one `import SomeWidgt from deformdemo.widgets`, or copy...

@stevepiercy I'll add separate PR's for the deform widgets first. First one is the Select2Sortable widget. Don't know how to link the deform and deformdemo PR's as they are interdependent