jdependency icon indicating copy to clipboard operation
jdependency copied to clipboard

Code cleanups

Open Goooler opened this issue 8 months ago • 4 comments

Goooler avatar Mar 31 '25 12:03 Goooler

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.32%. Comparing base (bac5a57) to head (2def472). Report is 115 commits behind head on master.

Files with missing lines Patch % Lines
src/main/java/org/vafer/jdependency/Clazz.java 25.00% 3 Missing :warning:
src/main/java/org/vafer/jdependency/Clazzpath.java 83.33% 0 Missing and 1 partial :warning:
...a/org/vafer/jdependency/utils/DependencyUtils.java 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #338      +/-   ##
============================================
+ Coverage     79.07%   79.32%   +0.24%     
+ Complexity       72       70       -2     
============================================
  Files             6        6              
  Lines           239      237       -2     
  Branches         27       27              
============================================
- Hits            189      188       -1     
+ Misses           37       36       -1     
  Partials         13       13              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Mar 31 '25 12:03 codecov-commenter

Thanks for the contribution but I don't subscribe to all those changes. Could you please provide some context?

tcurdt avatar Mar 31 '25 18:03 tcurdt

Thanks for the contribution. I would love to apply some of it. But it has too many changes that I am not keen on. I'll mark the ones I think are worth having.

tcurdt avatar Apr 09 '25 10:04 tcurdt

Sounds good!

Goooler avatar Apr 09 '25 10:04 Goooler

Thanks for the contribution but I cannot really apply it as is.

tcurdt avatar Jul 04 '25 11:07 tcurdt