tcWebHooks icon indicating copy to clipboard operation
tcWebHooks copied to clipboard

Password field is in plan text

Open alwaysharsha opened this issue 1 year ago • 2 comments

Expected Behavior

Password field shouldn't be exposed in plain text

Current Behavior

Currently, the password field is in plain text image

Steps to Reproduce (for bugs)

Refer screen above when providing the credentials in basic it is capturing the credentials in plain text

Your Environment

  • tcWebHooks Version: 1.2.2
  • TeamCity Version: 2023.5.3
  • TeamCity server Operating System: Windows Server 2016
  • Are you using a WebHook Template?: Yes

Example Configuration (xml)

alwaysharsha avatar Sep 27 '23 08:09 alwaysharsha

Hi @alwaysharsha

The best option is to use a WebHook Parameter set as "password". TeamCity will store it outside your build settings in an encrypted file.

Then reference the WebHook Parameter in the password field of your webhook authentication settings.

See this page for more information: https://github.com/tcplugins/tcWebHooks/wiki/Hiding-Sensitive-Values-In-WebHook-Configuration

Here is an example I have on my test server...

image

And then referenced in a webhook image

netwolfuk avatar Sep 27 '23 09:09 netwolfuk

BTW, the webhook configuration is stored on the teamcity server un-encrypted (I can't change how that works). So any implied security by using a hidden field in the webhook edit dialog would be mis-leading. That is why is it a plain text box, so that it's obvious that it won't be stored securely.

Referencing a secure WebHook Parameter is the better option.

netwolfuk avatar Sep 27 '23 09:09 netwolfuk

I'm going to close this out. Using a secure WebHook Parameter is the way to resolve this.

netwolfuk avatar May 25 '24 09:05 netwolfuk