wkhtmltox icon indicating copy to clipboard operation
wkhtmltox copied to clipboard

Fixed the logs handling

Open ms76 opened this issue 1 year ago • 2 comments

I created this pull request because I thought it would be better to handle loggers in the caller code, not in the library.

Let me explain how I came up with this pull request.

The logger was changed to ssi-logger in version 1.1.6. Since ssi-logger depends on modern-syslog and modern-syslog is a native addon, updating from 1.1.5 to 1.1.6 required a build environment such as g++ or make with npm install. I noticed this issue this time when npm install failed on my environment on CI and I could not update to 1.1.6.

I don't think it's intended that a patch version update changes the required environment, and I think it's more convenient to handle the logger on the outside.

I have also added a test and would be happy to merge the pull request.

ms76 avatar Apr 27 '23 12:04 ms76

@tcort Can you please confirm this pull request?

ms76 avatar May 19 '23 08:05 ms76

This change was necessary when upgrading from Node 16 to 18, also due to modern-syslog. Along with the version of deasync specified by ssi-logger being locked to 0.1.26, which doesn't support 18 - though the latest version of that library (0.1.28) does, so that could've been worked around.

jamesshaw1987 avatar Sep 28 '23 11:09 jamesshaw1987