markdown-link-check icon indicating copy to clipboard operation
markdown-link-check copied to clipboard

Possible failure when fetching URLs with escape characters?

Open thanethomson opened this issue 2 years ago • 1 comments

It appears as though markdown-link-check fails to resolve https://en.wikipedia.org/wiki/TLA%2B - it continually gets a 400 response.

An example in CI: https://github.com/tendermint/tendermint/runs/5456708726?check_suite_focus=true

This GitHub Action currently uses markdown-link-check v3.8.7. Not sure if this has perhaps been fixed since?

thanethomson avatar Mar 07 '22 23:03 thanethomson

I believe the issue has not been fixed yet. I am experiencing the same issue on markdown-link-check v3.9.0, v3.9.2, v3.9.3, and v3.10.0. markdown-link-check gets a 400 from https://img.shields.io/badge/%20imports-isort-%231674b1?style=flat&labelColor=ef8336, but Chrome gets a 200. In my case I was able to simply remove %20 and %23 from the URL, and the isort badge still works. For others looking for a workaround, maybe try the replacementPatterns configuration option.

Kurt-von-Laven avatar Apr 07 '22 23:04 Kurt-von-Laven