image-webpack-loader
image-webpack-loader copied to clipboard
tcoopman
Added ability to use additional optimizers
To add the ability to use additional optimizers without editing the core loader, I have added the option additionalPlugins to the loader options. Using this, a user can define an additional imagemin plugin to use, along with it's options, and the loader will utilize that optimizer as well (as long as it is installed as a node module).
sorry for the late review. Can you add a test where you add an additional optimizer?
I think this is good. Yeah, tests are required. @tcoopman I guess you can add the tests in this PR. or else I will fork @ShawnCorrigan 's branch and will add tests and submit a follow-up PR for the tests
aah...I cant fork his repo and keeping my existing fork. And even if I am forking his repo, I guess he is not active in GitHub so it might not get merge there.
I guess you can merge this and I will add tests
I am active enough, I will accept any PRs towards my repo. I just never had time to write tests for this.
I am active enough, I will accept any PRs towards my repo. I just never had time to write tests for this.
Ohh...I saw your GH contribution graph and thought of that. Nevermind. Will submit a PR in your fork soon
Sounds good! I'll keep an eye out for a PR. I am only contributing to private repos right now, but I do want to get back into open source development.
Sounds good! I'll keep an eye out for a PR. I am only contributing to private repos right now, but I do want to get back into open source development.
Great to hear that 👍
@ShawnCorrigan after rebasing , you need to update the schema.json as well to add this new configuration property.