flump icon indicating copy to clipboard operation
flump copied to clipboard

Sprites with size larger than 2046px break preview mode

Open mathieuanthoine opened this issue 9 years ago • 6 comments

Hi,

If a FLA created for Flump has a Sprite with a width or height larger than 2046 pixels, the preview mode is broken (lists of Movie and Texture are empty). Show Atlas and export seem to work correctly.

mathieuanthoine avatar Dec 27 '15 20:12 mathieuanthoine

While this is probably a bug, I still would suggest to break such big sprites into pieces. This leads to better performance on mobile devices.

markknol avatar Dec 28 '15 08:12 markknol

Even if it's better for mobile to have smaller sprite sheets, it's still a bug :)

PS: If you set a restriction on size, it could be better to set to 2048 and not 2046 :). It could be used for Desktop games :)

mathieuanthoine avatar Dec 28 '15 21:12 mathieuanthoine

I'm guessing the reason it breaks at > 2046 (rather than 2048) is because we add a 2px padding to textures by default. And we don't currently properly support 4K texture atlases, which your > 2046 texture is necessitating. This has been on my TODO list for a while but I've been neglecting Flump while I try to ship my game :)

tconkling avatar Jan 02 '16 20:01 tconkling

thank you for the explanations, it's clearer now :) If you need help to fix the bug, don't hesitate.

mathieuanthoine avatar Jan 02 '16 21:01 mathieuanthoine

Oh, I'm always happy for help fixing bugs! Please do look into it if you're able. I can help point you in the right direction - it's just that my Flump dev time is pretty limited these days.

On Sat, Jan 2, 2016 at 4:56 PM, mathieuanthoine [email protected] wrote:

thank you for the explanations, it's clearer now :) If you need help to fix the bug, don't hesitate.

— Reply to this email directly or view it on GitHub https://github.com/tconkling/flump/issues/144#issuecomment-168431027.

tconkling avatar Jan 02 '16 22:01 tconkling

I can help point you in the right direction Please :)

mathieuanthoine avatar Jan 02 '16 23:01 mathieuanthoine