Ted Conbeer

Results 37 issues of Ted Conbeer

While it's possible to run sqlfmt from the terminal inside VS Code, they support 3rd party formatters via their extensions API, and it would be great if we could support...

enhancement
help wanted

Some jinja expressions contain keywords, but they're all just formatted like names. For example, `{{ dbt_utils.group_by(n) }}` tends to get wrapped onto the line above it. sqlfmt doesn't have any...

enhancement

**Describe the bug** The `--fmt: off` tags should stop all formatting of the contained code, but today that is not the case, since comments may be rendered differently in those...

bug

Right now there are two rulesets, main and jinja. This made some sense when rulesets were MECE, since in this case they were lexing two totally different languages. However, we...

refactor

Postgres: https://www.postgresql.org/docs/15/sql-grant.html Snowflake (multiple pages): https://docs.snowflake.com/en/sql-reference/sql/grant-ownership.html BQ: https://cloud.google.com/bigquery/docs/reference/standard-sql/data-control-language#grant_statement

enhancement

/tests/data/unformatted is getting too big, slowing down the API tests. Plus it could probably be organized better, given that it will continue to grow with all the new ddl tests

refactor

sqlfmt was made for dbt, and originally only formatted `select` statements. Additional syntax is being added all the time. The list below represents the current functionality of sqlfmt `@main`. To...

enhancement

The most common ddl in our test files is `create function`. Let's start there. Postgres: https://www.postgresql.org/docs/15/sql-createfunction.html Snowflake: https://docs.snowflake.com/en/sql-reference/sql/create-function.html BigQuery: https://cloud.google.com/bigquery/docs/reference/standard-sql/user-defined-functions #262

enhancement

**Describe the bug** We are not going to create a full SQL grammar, but we should know that tokens that appear after the `as` keyword are aliases, and therefore are...

enhancement

Related to tconbeer/sqlfmt-docs#11 SQLFluff outputs JSON annotations for use with another GHA to annotate PRs. This is really nice! We should do this too. [More](https://github.com/sqlfluff/sqlfluff-github-actions/tree/main/menu_of_workflows/drizly). Option could be either `--diff-json`...

enhancement
help wanted