Ted Conbeer comments

Results 58 comments of


                                            Ted Conbeer

Column formatting breaks with unary operators

This was partially fixed in 0.22.0, released yesterday. The current output from the example above is now: ```sql select amount_in_cents / 100.0 as amount, - amount as charged_amount, resulting_balance_in_cents /...

Markdown Preview doesn't work with atom-dbt

Solution 2 works great. Thanks, @clrcrl !

feat: Support parsing of SQL code blocks in Markdown files

Thank you for this! I'm mostly away from my computer this week but I'll try to review next week.

feat: Support parsing of SQL code blocks in Markdown files

@michael-the1 Sorry I dropped the ball on this. I'd love to get this finalized. Looks like there are quite a few failing tests and lints. Do you want to work...

Support for formatting SQL code blocks in Markdown

I like this idea. I think we'd support this by installing a markdown parser as an extra (e.g., mistletoe or marko), iterating through the code blocks in the AST, and...

sqlfmt breaks up depends_on statements across multiple lines, causing an error in parsing

I can't reproduce this, with or without `jinjafmt`. I get: ```bash ~/open/sqlfmt main ≡  3.11 ❯ sqlfmt - 10:17:25 -- depends_on: {{ref('xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx') }} -- depends_on: -- {{ref('xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx') }} 1...

sqlfmt breaks up depends_on statements across multiple lines, causing an error in parsing

yeah ok that did it. thanks for the report.

sqlfmt breaks up depends_on statements across multiple lines, causing an error in parsing

Thanks. It's this method: https://github.com/tconbeer/sqlfmt/blob/e9205a9acaaa8726b6e35bb7e5a2244cbaff5860/src/sqlfmt/comment.py#L146-L163 Probably best to check the contents of the comment for a jinja tag (`{{...}}` or `{%...%}` pair) and skip splitting the comment if we find...

sqlfmt breaks up depends_on statements across multiple lines, causing an error in parsing

closed by #642

[BUG] spinning forever in _split_cells with negative cut

Thanks, @willmcgugan !