acts_as_follower icon indicating copy to clipboard operation
acts_as_follower copied to clipboard

no deprecation warning if custom_parent_classes==[]

Open brchristian opened this issue 9 years ago • 8 comments

As mentioned in https://github.com/tcocca/acts_as_follower/pull/89#issuecomment-288847274 and in some of the issues like https://github.com/tcocca/acts_as_follower/issues/91, the current master version is issuing unnecessary deprecation warnings when custom_parent_classes == [].

Merging #89 will make this PR moot, because that refactors away the custom_parent_classes object entirely. That would be my personal recommendation.

But, if there is hesitation to merge #89 for whatever reason, then we can at least merge this in the meantime and remove some of those unnecessary warnings. We could then aim to merge #89 at some later point in time.

brchristian avatar Mar 24 '17 17:03 brchristian

:+1: Would love to see this merged in. My test suite gets spammed with these deprecation messages atm!

Tybot204 avatar Mar 28 '17 00:03 Tybot204

Same thing here! 👍 Good work, guys.

mion avatar Mar 28 '17 23:03 mion

Please merge this in :).

cenderin avatar Jul 27 '17 22:07 cenderin

Is there a way to pull this into the gem locally and use it? edit Change your gem file to the following. gem 'acts_as_follower', github: 'brchristian/acts_as_follower', :branch => 'patch-1'

JerryArns avatar Sep 23 '17 03:09 JerryArns

Merge, please =)

iguanus avatar Apr 04 '18 16:04 iguanus

Merge possible?

kidbombay avatar Jul 18 '18 13:07 kidbombay

Merge please! :+1:

vsppedro avatar Jan 24 '19 19:01 vsppedro

We still need a merge....But on another note - Please optimize the embedded queries to minimize the the chance of receiving an n+1 query.

RailsCod3rFuture avatar Feb 04 '19 21:02 RailsCod3rFuture