no deprecation warning if custom_parent_classes==[]
As mentioned in https://github.com/tcocca/acts_as_follower/pull/89#issuecomment-288847274 and in some of the issues like https://github.com/tcocca/acts_as_follower/issues/91, the current master version is issuing unnecessary deprecation warnings when custom_parent_classes == [].
Merging #89 will make this PR moot, because that refactors away the custom_parent_classes object entirely. That would be my personal recommendation.
But, if there is hesitation to merge #89 for whatever reason, then we can at least merge this in the meantime and remove some of those unnecessary warnings. We could then aim to merge #89 at some later point in time.
:+1: Would love to see this merged in. My test suite gets spammed with these deprecation messages atm!
Same thing here! 👍 Good work, guys.
Please merge this in :).
Is there a way to pull this into the gem locally and use it?
edit
Change your gem file to the following.
gem 'acts_as_follower', github: 'brchristian/acts_as_follower', :branch => 'patch-1'
Merge, please =)
Merge possible?
Merge please! :+1:
We still need a merge....But on another note - Please optimize the embedded queries to minimize the the chance of receiving an n+1 query.