Marcel Kost

Valgrind memcheck with `--leak-check=full --show-leak-kinds=all` doesn't find any problems: ``` ==14894== LEAK SUMMARY: ==14894== definitely lost: 0 bytes in 0 blocks ==14894== indirectly lost: 0 bytes in 0 blocks ==14894==...

The error didn't appear after rerunning travis without code changes: https://travis-ci.org/cmu-db/peloton/builds/392879558

@crd477 Does the workspace also include the logs? Because in general we want to keep them as long as possible, at least one week. We had the problem already that...

@crd477 It was some weeks ago, I can't find it anymore. Probably it got caused by Jenkins changes at that time. I will tell you, if it happens again.

I would check in `validate_file(file_path)` [1] if the file matches `/test/*/*.cpp` and then run the check in addition to the other checks. This way every test file that the validator...

> How do I check the methods? They don't follow a prefix/suffix pattern. You can use a regex to find these lines and extract the information. (see example: https://regexr.com/3nnro) >...

Ah sorry, I got you wrong. The [naming conventions](https://github.com/cmu-db/peloton/blob/master/test/README.md#naming-conventions) say, that every method (test case) should have the suffix `Test`.

> Yeah, but a lot of test cases across different test files do not. Are we going to use the validator script to fix all these files? Correct, that's the...

@schedutron No, we don't provide automated fixing. We expect people to fix their violations manually ;)

Hey, I fear you screwed up the code when resolving the merge conflicts in 2f28acc. This is also the reason the tests fail. I think the easiest way to solve...