python-ring-doorbell icon indicating copy to clipboard operation
python-ring-doorbell copied to clipboard

Make library fully async

Open sdb9696 opened this issue 1 year ago • 2 comments

sdb9696 avatar Mar 26 '24 13:03 sdb9696

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - Generic High Entropy Secret 1fd72a9bca25bfeb73a1990eb9eb2f12c6987831 tests/fixtures/ring_oauth.json View secret
- - Generic High Entropy Secret 1fd72a9bca25bfeb73a1990eb9eb2f12c6987831 tests/fixtures/ring_oauth.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Mar 26 '24 13:03 gitguardian[bot]

Coverage Status

coverage: 79.015% (-0.8%) from 79.822% when pulling 4796d3a7b310ed9045a4d851e829e923710e903a on sdb9696:make_lib_async into 8d4f555e850838ab2d78381af1867b1863ffb25f on tchellomello:master.

coveralls avatar Mar 26 '24 13:03 coveralls

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Jul 04 '24 15:07 github-actions[bot]

Coverage Status

coverage: 77.812% (-0.8%) from 78.571% when pulling ba9274985434b214796aa8773d9329df337ec5cd on sdb9696:make_lib_async into ab2a2aab401bfe7d0cd9942d399bcab4e1eeb1e4 on tchellomello:master.

coveralls avatar Aug 08 '24 13:08 coveralls