python-ring-doorbell icon indicating copy to clipboard operation
python-ring-doorbell copied to clipboard

Function get_snapshot() in doorbot needs attention

Open mskoster opened this issue 2 years ago • 3 comments

Line 441: if response["timestamps"][0]["timestamp"] / 1000 > request_time: here the division by 1000 seems to be incorrect. I guess Ring changed the response format. Propose to change to if response["timestamps"][0]["timestamp"] > request_time:

Line 443: SNAPSHOT_ENDPOINT.format(self._attrs.get("id")), raw=True here the raw parameter is invalid in the call to self._ring.query(). Propose to change to SNAPSHOT_ENDPOINT.format(self._attrs.get("id"))

Kind Regards, Martin

mskoster avatar Sep 12 '22 15:09 mskoster

Good catch! Thanks for sharing.

budachst avatar Dec 05 '22 07:12 budachst

I have made the above changes and still can't get any snapshots.

ericm301 avatar Aug 18 '23 22:08 ericm301

The fix works for me!

nathankrueger avatar Nov 12 '23 21:11 nathankrueger

There hasn't been any activity on this issue recently. This issue has been automatically marked as stale because of that. It will be closed if no further activity occurs. Please make sure to update to the latest ring_doorbell version and check if that solves the issue. Thank you for your contributions.

github-actions[bot] avatar Apr 18 '24 18:04 github-actions[bot]