markdown-links icon indicating copy to clipboard operation
markdown-links copied to clipboard

Error report from VS Code extension monitor - perhaps the source of the large graph performance issue?

Open nixsee opened this issue 5 years ago • 2 comments

  • Issue Type: Bug
  • Extension Name: markdown-links
  • Extension Version: 0.7.0
  • OS Version: Windows_NT x64 10.0.19042
  • VSCode version: 1.47.3

:warning: We have written the needed data into your clipboard. Please paste! :warning:

{
	"messages": [],
	"activationTimes": {
		"codeLoadingTime": 12,
		"activateCallTime": 0,
		"activateResolvedTime": 1,
		"activationReason": {
			"startup": false,
			"extensionId": {
				"value": "tchayen.markdown-links",
				"_lower": "tchayen.markdown-links"
			},
			"activationEvent": "onLanguage:markdown"
		}
	},
	"runtimeErrors": [
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		},
		{
			"name": "Error",
			"message": "Webview is disposed"
		}
	]
}

nixsee avatar Aug 03 '20 22:08 nixsee

I've run into this as well. I don't think its a performance thing, but in my experience it just causes the graph to completely break. I think the extension needs to listen for panel.onDidDispose() and do something smart. No clue what causes the panel to dispose though.

ianjsikes avatar Aug 14 '20 00:08 ianjsikes

Hm, listening to onDispose is one thing, but what to do with that is another. Should it be immediately reopen? Should we assume that disposed webview means that the tab closed in the editor?

I feel like any information that moves us in a proper direction is needed before handling that.

tchayen avatar Aug 16 '20 14:08 tchayen