thomas chaton comments

Results 276 comments of


                                            thomas chaton

LightningModule self.log add_dataloader_idx doesn't reduce properly the metric across dataloaders

Hey @rohitgr7. What do you think should be the default behavior here ? Not sure to understand your answer.

LightningModule self.log add_dataloader_idx doesn't reduce properly the metric across dataloaders

Hey @carmocca @rohitgr7. I would personally support @carmocca option 3: `Fully implement cross-reduction` with the following behavior ```py def ... # This won't reduce metrics across dataloaders and adds or...

[Bug] sglang doesn't stop the generation when the request is canceled

Hey @merrymercy @jhinpan I wondered if this would be considered. This is making very dynamic inference with long context length quite challenging.

[FEATURE] Comparaison to LitData

Thanks @istranical, I copied the wrong link, I meant Litdata: https://github.com/Lightning-AI/litdata

Support `str(datamodule)`

Hey @carmocca, I believe adding support for str() provides the same inconvenient as using len(). It might be worth to consider a `describe` LightningDataModule method instead. Best, T.C

`OutOfBoundsError` when streaming parquet files with `low_memory=True`

@bhimrazy I wonder if the issue isn t coming from the compression where we start reading from the file before it is fully there