Tobin C. Harding

FTR this is upgrade only with minimal changes, I did not attempt an improvements that may be possible with the upgrade eg., using `Amount` instead of `u64` (I just converted...

ATM I don't know what the CI failure means: - bug in this patch - bug in the way weight and/or fee rate are used - Or, most likely, a...

Sounds plausible and likely. Thanks for investigating for me. I'll re-spin this with your fix.

@notmandatory you mean the bug was hiding in the line of code with **9 lines of comments** describing why it was there, I probably could have looked a bit harder...

Note @apoelstra this is the 0.31 upgrade not the 0.32 upgrade (using secp 0.28 so `ThirtyTwoByteHash` should still be implemented on `hashes` types, we only just removed it in secp...

> Instead of being fancy, I think if we just call sign_psbt_ecdsa individually for each case The `bdk` signing is not using the PSBT signing API from `rust-bitcoin`, you guys...

Just for the record, this PR does not attempt to use any of the improvements in the new `rust-bitcoin` version (assuming you see them as improvements). It just makes the...

Hi @ddimaria, can this issue be closed now? I'm a bit late to the party but thanks for letting us know.

I think this can be closed after #119 and #120 go in?

Relevant comment by @apoelstra about async in this crate (so I can find it later: https://github.com/rust-bitcoin/rust-miniscript/pull/662#issuecomment-2089148672)