test262 icon indicating copy to clipboard operation
test262 copied to clipboard

merge immutable-arraybuffer tests

Open phoddie opened this issue 8 months ago • 7 comments

Suite of test262 tests for the Immutable ArrayBuffer proposal.

phoddie avatar Apr 01 '25 20:04 phoddie

Sure, will do. FWIW – "Fix the copyrights to a single year rather than a range" feels artificial.

phoddie avatar Apr 04 '25 17:04 phoddie

It's not; it ensures that the range doesn't need to be updated every year.

ljharb avatar Apr 04 '25 17:04 ljharb

Rebasing on main will also get the annotation improvements from #4449.

gibson042 avatar Apr 04 '25 17:04 gibson042

It's not; it ensures that the range doesn't need to be updated every year

??? The range only needs to be updated in years when the tests are modified, not when the calendar advances. Anyway. I will change the tests to conform with this peculiar requirement.

phoddie avatar Apr 04 '25 17:04 phoddie

The linter is now happy and I've attempted to resolve all comments.

phoddie avatar Apr 04 '25 22:04 phoddie

Thanks for the review @anba. This is very helpful.

I'd prefer not to make this PR any bigger so let's not fix the missing coverage here, instead please consider opening an issue with a testing plan.

ptomato avatar May 07 '25 12:05 ptomato

The helpful feedback from @anba have been applied.

As per discussion with @gibson042, we'll break this up into multiple PRs based on the test plan, when available.

phoddie avatar May 14 '25 17:05 phoddie

The changes of this PR have now been incorporated into scoped PRs linked to from the test plan.

gibson042 avatar Jul 29 '25 16:07 gibson042