test262 icon indicating copy to clipboard operation
test262 copied to clipboard

Tests using `__proto__` without appropriate `features` entry

Open linusg opened this issue 1 year ago • 1 comments

Found some randomly (there may be more, only did a quick search):

https://github.com/tc39/test262/blob/e4f91b6381d7694265031caad0c71d733ac132f3/test/built-ins/TypedArrayConstructors/ctors/no-species.js#L29

https://github.com/tc39/test262/blob/e4f91b6381d7694265031caad0c71d733ac132f3/test/staging/ArrayBuffer/resizable/oobbehaves-like-detached.js#L25

https://github.com/tc39/test262/blob/e4f91b6381d7694265031caad0c71d733ac132f3/test/staging/ArrayBuffer/resizable/typed-array-prototype.js#L52

Unless __proto__ is actually relevant to the test, Object.get/setPrototypeOf() should be preferred IMO. __proto__ is "Normative Optional, Legacy", so new engines may not want to implement it (which is how I ended up here to begin with :^)).

For reference:

https://github.com/tc39/test262/blob/e4f91b6381d7694265031caad0c71d733ac132f3/features.txt#L258

linusg avatar Jan 29 '24 19:01 linusg

Instead of using Object.getPrototypeOf, there should probably be a test helper that uses both, since there are engines that have dunder proto but not getPrototypeOf.

ljharb avatar Jan 29 '24 19:01 ljharb