test262 icon indicating copy to clipboard operation
test262 copied to clipboard

Migrate resizable buffer tests out of staging

Open syg opened this issue 2 years ago • 6 comments

This PR migrates all resizable buffer tests out of staging into the main test suite. Tests that multiple similar methods at once are split up to to multiple files to be consistent with the existing directory structure.

No tests have been removed.

test/built-ins/ArrayBuffer/prototype/resize/coerced-new-length-detach.js is a new test that tests the normative detach timing change from the July 2023 TC39.

syg avatar Jul 28 '23 21:07 syg

Review ping.

syg avatar Sep 12 '23 00:09 syg

Review ping.

@syg A few of us have started to review this over the past weeks but unfortunately it's quite large. We're trying to find a way for someone to commit time to it and failing that will otherwise try to split it up between maintainers. Thanks for your patience.

ptomato avatar Sep 13 '23 16:09 ptomato

@ptomato Thanks. If it helps, this PR just splits up existing tests in staging, following the principle that each test262 tests for a single "behavior".

syg avatar Sep 15 '23 23:09 syg

Another ping.

syg avatar Oct 27 '23 18:10 syg

I created PR #4030 which has a helper file with a lot of the duplicated code from the files in this PR.

During the maintainers meeting yesterday we decided that when PR #4030 is merged, I will be removing the duplicated code from the test files of this PR, and will be adding the cleaned up tests to separate smaller PRs, split by method. The goal is to make it easier to split up the review load. When each smaller PR gets merged we plan to rebase this PR so that it keeps getting smaller and we make sure we didn't forget anything.

ioannad avatar Mar 28 '24 16:03 ioannad

Rebased after merging all of the tests belonging to Array and TypedArray methods.

ptomato avatar Aug 15 '24 22:08 ptomato