tc39
add tests for array.prototype.groupByToMap
Wow! This is a great head start here :) Let's wait until our video call on Friday to do a review together.
Similarly to #3354, i think this could use some tests for throwing on a non-function callback, but otherwise it matches my polyfill's tests!
re. exhaustive features list, shrug; the documentation in features.txt says about stage 4 features:
Language features that have been included in a published version of the ECMA-262 specification. These flags are largely maintained for historical reasons, though their use for relatively new features (i.e. prior to availability across major implementations) is appreciated.
I don't think these are "relatively new" and it seems burdensome to contributors who just want to get their tests landed, for us to require them. Many of them can be added automatically anyway should anyone complain.
It's totally fine to land this without them, and i can add them to #3664.
However, if we want test262 to ever be usable on packages - which tend to have long lists of supported platforms - exhaustive feature lists are a critical thing to have to ensure that's achievable.
Fair enough, I'd say we should avoid putting that burden on test contributors though :smile:
Let's open an issue to review that documentation in features.txt and do something like add a pre-commit script that will automatically add as many features as possible.
Agreed, let's land this now as it's been waiting for a long time, and update #3664