test262 icon indicating copy to clipboard operation
test262 copied to clipboard

Permit Symbol as WeakMap key and WeakSet entry. Closes gh-2850

Open rwaldron opened this issue 5 years ago • 2 comments

For changes that are explicitly relevant to "Permit Symbol as WeakMap key and WeakSet entry", see commit 1.

rwaldron avatar Nov 02 '20 19:11 rwaldron

This needs to be updated so that it also checks that symbols are valid WeakRef targets.

ExE-Boss avatar Feb 17 '21 19:02 ExE-Boss

@leobalter does your change in https://github.com/tc39/ecma262/compare/main...leobalter:symbol-as-weakmap-key cover @ExE-Boss's comment? I was expecting to see something like:

- 2. If Type(target) is not Object, throw a TypeError exception.
+ 2. If HasIdentity(target) is false, throw a TypeError exception.

Am I misunderstood?

rwaldron avatar Dec 02 '21 15:12 rwaldron