proposal-signals icon indicating copy to clipboard operation
proposal-signals copied to clipboard

Polyfill bug: throwing during watched/unwatched interrupts algorithm

Open littledan opened this issue 10 months ago • 1 comments

We have to make sure that the full graph coloring algorithm runs to completion before triggering any watched/unwatched callbacks. As things stand today, I think an exception thrown at the wrong time will leave the signal graph in a bad state. The algorithm descriptions in the readme should also clarify that this bad state doesn’t happen.

littledan avatar Mar 30 '24 03:03 littledan

maybe errors during watched/unwatched should be handled like an unhandled promise rejection and reported in its own stack? rxjs has a global reportError that by default forwards to globalThis.reportError or console.error afair.

backbone87 avatar Apr 08 '24 20:04 backbone87