proposal-iterator-helpers issues

Utility to push to an iterable

1

It'd be very useful to have something that pushes to an iterable, and in fact, it's pretty critical for adapting any push-based API to async iterators. Of course, there's not...

dead-claudia

`.take` should close the underlying iterator as soon as the final item is taken

8

Right now if you do ```js let bounded = iter.take(3); bounded.next(); bounded.next(); bounded.next(); ``` this will not close `iter`. You have to call `bounded.next()` again to actually close out the...

bakkot

fixes #219: take closes iterator earlier

Fixes #219. Draft until I do the same for async `take`.

michaelficarra

avoid using PromiseResolve with a value known not to be a Promise

1

A slight tweak to https://github.com/tc39/proposal-iterator-helpers/pull/215. The reason to use PromiseResolve is to get the fast-path when the value being passed is expected to be a Promise. On this particular line...

bakkot

taking Infinity or dropping 0

1

Should `iter.take(Infinity)` or `iter.drop(0)` return `iter` instead of wrapping it unnecessarily?

michaelficarra

"built-in async function"s are underspecified

2

The async versions of the consuming helpers - `toArray`, etc - are specified as "built-in async function"s. But I don't think we've ever actually said what that means anywhere. The...

bakkot

forEach return value

10

As written today, the return value of `forEach` is undefined. I believe this would miss an opportunity to return the `value` from the final `{done: true, value}` iteration result of...

kriskowal