proposal-extractors icon indicating copy to clipboard operation
proposal-extractors copied to clipboard
verified publisher icon tc39

Support elision in extractor expression cover grammar

Open rbuckton opened this issue 1 year ago • 4 comments

This changes the grammar to use a cover for Arguments that includes the Elision elements necessary to support ExtractorAssignmentPattern.

Fixes #23

rbuckton avatar May 28 '24 22:05 rbuckton

A preview of this PR can be found at https://tc39.es/proposal-extractors/pr/29.

github-actions[bot] avatar May 28 '24 22:05 github-actions[bot]

is this a user-aware syntax change or is it just make things technically correct?

Jack-Works avatar May 29 '24 05:05 Jack-Works

This fixes the cover grammar to match the ExtractorAssignmentPattern grammar so that F(, x) = y parses as intended.

rbuckton avatar May 29 '24 13:05 rbuckton

@waldemarhorwat does this sufficiently cover your concern about Elision missing from the cover grammar from #23? I've opted for option 2 in https://github.com/tc39/proposal-extractors/issues/23#issuecomment-2135970793 for the time being, and can revise based on the outcome of the discards proposal.

rbuckton avatar Sep 06 '24 15:09 rbuckton

FYI, unless anyone has comments on this PR, I plan to merge it later this evening.

rbuckton avatar Sep 26 '24 23:09 rbuckton