proposal-binary-ast icon indicating copy to clipboard operation
proposal-binary-ast copied to clipboard

Parameter binding lists should force parameters bindings to be enumerated in source order.

Open efaust opened this issue 6 years ago • 4 comments

Right now the reference encoder feels free to sort parameter bindings lexicographically, which doesn't play nicely with engines.

efaust avatar Apr 12 '18 18:04 efaust

What's the problem, exactly? Default arguments?

Yoric avatar Apr 12 '18 18:04 Yoric

@efaust Is this still a problem? Do you want me to do something about this?

Yoric avatar Apr 24 '18 14:04 Yoric

CheckParameterNames checks the order in step 5: https://binast.github.io/ecmascript-binary-ast/#sec-checkparameternames

and actualParams has names in the syntactical order: https://tc39.github.io/ecma262/#sec-function-definitions-static-semantics-boundnames

so, if the order doesn't match, it's the reference encoder's bug. I'll check it shortly

arai-a avatar Jul 27 '18 06:07 arai-a

moved the issue to binjs-ref. I'd suggest closing this issue.

arai-a avatar Jul 31 '18 06:07 arai-a