ecma402 icon indicating copy to clipboard operation
ecma402 copied to clipboard

Editorial: Use named records for DateTimeFormat format records

Open anba opened this issue 1 year ago • 2 comments

This PR aims to restructure Intl.DateTimeFormat Constructor - Internal Slots to use named Record types instead of ad-hoc records. In the process of this clean-up, some editorial bugs were found and fixed, see the commit messages for details.

In addition to providing a more type-safe approach when compared to using ad-hoc records, these changes should also help with the Temporal integration, see https://tc39.es/proposal-temporal/#sec-temporal-intl.


The PR applies on top of #822.

anba avatar Aug 11 '23 13:08 anba

Fixed all review comments and rebased the commits to apply cleanly on tip.

anba avatar Oct 18 '23 11:10 anba

Rebased again.

Do we still wait for another review or can we land these changes?

anba avatar Dec 15 '23 10:12 anba

@anba I've rebased this onto the current main on my own fork: https://github.com/ben-allen/ecma402/tree/anba-826-working-branch. If you pull it in, I can merge.

ben-allen avatar Apr 03 '24 03:04 ben-allen