ecma262 icon indicating copy to clipboard operation
ecma262 copied to clipboard

Markup: New & better graphics, remove spec css element

Open gesa opened this issue 1 year ago • 2 comments

Do not merge until tc39/ecmarkup#600 is merged & updated.

gesa avatar Jun 13 '24 20:06 gesa

@syg

Is the plan that this needs to be manually updated every year? Is there a script to generate this?

It's an SVG, it should be very easy to do this:

image

michaelficarra avatar Jun 21 '24 22:06 michaelficarra

Alright cover will be automatically generated in the future, files live with ecmarkup.

gesa avatar Jul 03 '24 07:07 gesa

Should be ready, sorry for the delay @gesa. Unfortunately we don't have a copy of Prince so once this lands we'll need your help to confirm we didn't mess it up somehow.

bakkot avatar Mar 03 '25 23:03 bakkot

@bakkot there were some issues with ecmarkup v21, but here’s the ecma262 PDF pulled from main and built with ecmarkup a004373.

gesa avatar Mar 13 '25 01:03 gesa

@gesa Nice, thanks. I'll review in more detail later, but on a quick glance, noticed:

  • https://github.com/tc39/ecma262/pull/3549
  • the rendering for the slashed cell in Table 48 got messed up somehow
  • section headers in the annexes are centered rather than left-aligned

bakkot avatar Mar 13 '25 02:03 bakkot

@bakkot Annex headers are supposed to be centered, that’s one of the fixes in tc39/ecmarkup#638

I’ll take a look at the rest!

gesa avatar Mar 13 '25 21:03 gesa

@bakkot i made you a present. tc39/ecma262#3550

gesa avatar Mar 14 '25 00:03 gesa