ecma262 icon indicating copy to clipboard operation
ecma262 copied to clipboard

Editorial: Almost eliminate "unknown" as a parameter type

Open jmdyck opened this issue 3 years ago • 4 comments

In the current spec, there are 250 AO/SDO parameters with a type of "unknown". This PR replaces almost all of those unknowns with a reasonable type.

I say "almost all" because it skips:

  • the 3 _state_ parameters handled by PR #2741, and
  • the 5 _V_ and _W_ parameters of GetValue, PutValue, and InitializeReferencedBinding, because they're weird, and need some attention before they can get sensible types.

The PR is broken into commits according to what replaces "unknown", in case that helps review. Squash before merging.

jmdyck avatar Apr 18 '22 18:04 jmdyck

(force-pushed to resolve merge conflicts)

jmdyck avatar Aug 06 '22 03:08 jmdyck

FYI #2842 handles the 5 _V_ and _W_ parameters of GetValue, PutValue, and InitializeReferencedBinding. So after these two PRs, all unknown parameters should be eliminated, correct?

michaelficarra avatar Aug 08 '22 14:08 michaelficarra

FYI #2842 handles the 5 _V_ and _W_ parameters of GetValue, PutValue, and InitializeReferencedBinding.

Yes, I was planning to deal with those once #2744 was merged, but bakkot beat me to it!

So after these two PRs, all unknown parameters should be eliminated, correct?

Yup. There will probably be some lurking in in-flight PRs though.

jmdyck avatar Aug 08 '22 17:08 jmdyck

(force-pushed to resolve merge conflicts)

jmdyck avatar Aug 16 '22 00:08 jmdyck

force-pushed to rebase to main and address review comments.

jmdyck avatar Aug 30 '22 20:08 jmdyck

Force-pushed to rebase to main. Also added commits to address decisions from editors call.

jmdyck avatar Sep 03 '22 03:09 jmdyck

(force-pushed to resolve merge conflict)

jmdyck avatar Sep 14 '22 19:09 jmdyck

(force-pushed to squash it down to 2 commits)

jmdyck avatar Sep 23 '22 03:09 jmdyck