ecma262 icon indicating copy to clipboard operation
ecma262 copied to clipboard

Published 20 hours ago • verified publisher icon tc39

Normative: Update GetSubstitution to match reality

Open gibson042 opened this issue 6 years ago • 6 comments
trafficstars

$nn patterns fall back to $n when there aren't at least nn captures

Fixes gh-1426

Preview: https://deploy-preview-1732--ecma262-snapshots.netlify.com/#sec-getsubstitution

gibson042 avatar Oct 09 '19 01:10 gibson042

is this still a thing?

devsnek avatar Aug 16 '20 23:08 devsnek

I believe so - it needs test262 tests, a rebase, and an updated review.

ljharb avatar Aug 17 '20 01:08 ljharb

I'm planning to rebase and update this PR after #2021 lands.

gibson042 avatar Aug 18 '20 20:08 gibson042

@gibson042 #2021 has landed, do you want to rebase this?

michaelficarra avatar Oct 12 '20 21:10 michaelficarra

Yep, it should be done this week.

gibson042 avatar Oct 13 '20 16:10 gibson042

I think this already has tests, actually, or at least one test, as pointed out in the original issue.

bakkot avatar Aug 17 '21 01:08 bakkot

Replaced by #3157.

gibson042 avatar Aug 29 '23 14:08 gibson042