Tobias Bucher

Results 70 comments of Tobias Bucher

> In general, we feel like we're favoring an approach more like https://github.com/rust-lang/cargo/issues/3126 rather than this approach. (That still needs some details worked out, though.) It seems to me that...

> I can't speak for the others but I feel this proposal adds a lot of upfront complexity for people to depend on a crate when bases are being used....

> someone more is needed for the bus factor - but will close for now. I'd be interested in working more on this project again. I still seem to have...

@ticki Are these licenses really that incompatible? Can't I have a GPL program that has a Apache or MIT dependency?

> This seems unnecessarily complicated because the probe is only done once per program lifetime and stored in a static. This basically just uses the first `copy_file_range` syscall to observe...

> That is not correct. If I recall correctly RHEL would fail with ENOSYS on some files but with EOPNOTSUPP on others. Which means depending on which files you're hitting...

> I'd be happier with this with the following two changes: > > * lift the probe code up a few nesting levels by putting it into a `fn` >...

Changed the comment. @rustbot ready