Whitespace, syntax, and linting

[homebysix]

Many of the changes I've made were suggested by Shellcheck, and a few are personal preferences. Take what you like, leave the rest!

[tbridge]

Thanks Elliot! I’ll review!

Tom

On Jul 13, 2017, at 3:03 PM, Elliot Jordan [email protected] wrote:

Many of the changes I've made were suggested by Shellcheck https://github.com/koalaman/shellcheck/wiki, and a few are personal preferences. Take what you like, leave the rest!

You can view, comment on, or merge this pull request online at:

https://github.com/tbridge/munki-in-a-box/pull/23 https://github.com/tbridge/munki-in-a-box/pull/23 Commit Summary

Standardize whitespace Use $(..) instead of legacy .. Remove trailing whitespace For/do on one line, like if/then Remove unused variables No $echo var is defined Catch failed cd commands File Changes

M munkiinabox.sh https://github.com/tbridge/munki-in-a-box/pull/23/files#diff-0 (263) Patch Links:

https://github.com/tbridge/munki-in-a-box/pull/23.patch https://github.com/tbridge/munki-in-a-box/pull/23.patch https://github.com/tbridge/munki-in-a-box/pull/23.diff https://github.com/tbridge/munki-in-a-box/pull/23.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/tbridge/munki-in-a-box/pull/23, or mute the thread https://github.com/notifications/unsubscribe-auth/AADfKRTdEjAXKE9qvLuxIoXqJekeGjoAks5sNmnygaJpZM4OXaUS.