combyne icon indicating copy to clipboard operation
combyne copied to clipboard

Issue with filter arguments

Open tbranyen opened this issue 9 years ago • 3 comments

I tried passing:

{{ property|replace '-' ' ' }}

and the second argument appeared as ', ' instead of ' '

tbranyen avatar May 14 '15 22:05 tbranyen

What's the code of the filter you were using? I have almost the same filter in my application and it seems to be working as-expected

kadamwhite avatar Aug 25 '15 01:08 kadamwhite

@kadamwhite https://github.com/tbranyen/combyne/pull/74

tbranyen avatar Aug 25 '15 13:08 tbranyen

The bug is the result of: https://github.com/tbranyen/combyne/blob/master/lib/tree.js#L376-L377

We just need smarter parsing of the arguments. I think the tokenizer is fine, I think the stack is fine, it's just the tree building that is busted.

tbranyen avatar Aug 25 '15 20:08 tbranyen